-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠️ use local lit #58
🛠️ use local lit #58
Conversation
Can confirm, that this fixes my issue! |
Cool! |
Very true. Could include an additional ‘or’ |
I changed this in the top line of my file and didn't have any luck, still the same issue even after a restart of HomeAssistant |
@ZinkNotTheMetal doesn't require a restart, you need to clear your browser cache, however |
@iantrich thank you sir! |
Yes, but the build process would then import LitElement anyway. If it wasn't for the lost backwards compatibility I would merge this now. |
Yea I guess these people have a update to date HA. 0.80 is also 5 version behind, so for me this step would be ok |
@kalkih I think a note saying that future releases are only supported by 0.80+ is fair. |
Thanks for your feedback. |
@kalkih |
Interesting, that could indeed be an issue and cause to cards break, especially with lit and lit-element still being young and developed quite extensively. For now, my build process solves the issues related to externally loaded dependencies by bundling them in, the drawback being the additional size of the card. I'm going to remove the ability to use the source directly in the next release, since people still seem to do it, and it's causing unnecessary confusion and issues. |
I like the bundling idea and might see about adding to mine and suggesting it to others |
fixes #57